On Tue, Apr 27, 2010 at 1:16 PM, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote: > > I dunno what this pr_fmt() definition is doing here, but it has > unpleasant effects with a x86_64 allmodconfig build: >... > so I cheerily deleted it. Andrew, I apologize for the pain. I was trying to comply with a comment to my original patch: On Wed, Apr 21, 2010 at 3:50 PM, Joe Perches <joe@xxxxxxxxxxx> wrote: >> +#define lbtf_pr_info(format, args...) \ >> + printk(KERN_INFO DRV_NAME": " format, ## args) >> +#define lbtf_pr_err(format, args...) \ >> + printk(KERN_ERR DRV_NAME": " format, ## args) >> +#define lbtf_pr_alert(format, args...) \ >> + printk(KERN_ALERT DRV_NAME": " format, ## args) > > I think it'd be better to add > > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > > and use the more standard pr_<level>s. Unfortunately it turned into a mess, partly due to me wanting to keep the definition in only one place (my .h file) for the module, and partly to my lack of full understanding of the pr_fmt macro. "cheerily" deleting it is fine. I'll followup with a second (better) patch for that part if I don't like the result. Thanks, - Steve -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
