On Thu, Apr 22, 2010 at 11:33 PM, Luis R. Rodriguez <mcgrof@xxxxxxxxx> wrote:
> On Thu, Apr 22, 2010 at 9:42 AM, Pavel Roskin <proski@xxxxxxx> wrote:
>> On Thu, 2010-04-22 at 09:33 -0700, Luis R. Rodriguez wrote:
>>
>>> How was this compiling for older kernels before then?
>>
>> Compiling was fine, but loading the firmware was failing sometimes. I'm
>> glad somebody figured it out. Thank you, Grazvydas!
>
> OK Applied. I'm still puzzled, if it compiled, then that means
> dev_set_uevent_suppress() was being defined somehow for older kernels.
there was already ifdef, old code:
#if (LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,30))
dev_set_uevent_suppress(f_dev, 1);
#endif
new code:
#if (LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,30))
dev_set_uevent_suppress(f_dev, 1);
#else
f_dev->uevent_suppress = 1;
#endif
>> I would prefer to have replacement functions in compat-2.6.30.h rather
>> than ifdefs in the code. We might want to resync compat_firmware with
>> the kernel one day, and ifdefs would stand in the way.
>
> Good point, I merged the patch for now given that that file does't
> change that often upstream.
>
> Luis
>
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
