I reported this nearly a month ago here: http://comments.gmane.org/gmane.linux.kernel.wireless.general/48401 Had a chance to test your patch and everything's fine now. This bug has been existent since January. Great job! Walter. --- On Thu, 4/22/10, Grazvydas Ignotas <notasas@xxxxxxxxx> wrote: > From: Grazvydas Ignotas <notasas@xxxxxxxxx> > Subject: [PATCH] compat: fix uevent_suppress on 2.6.29 or older kernels > To: "Luis R. Rodriguez" <mcgrof@xxxxxxxxx> > Cc: linux-wireless@xxxxxxxxxxxxxxx, "Grazvydas Ignotas" <notasas@xxxxxxxxx> > Date: Thursday, April 22, 2010, 9:54 AM > Missing uevent_suppress is causing > two uevents instead of one, which is > confusing udev and sometimes causing firmware load to fail > due to race > condition, so let's add it. > > Signed-off-by: Grazvydas Ignotas <notasas@xxxxxxxxx> > --- > compat/compat_firmware_class.c | 6 +++++- > 1 files changed, 5 insertions(+), 1 deletions(-) > > diff --git a/compat/compat_firmware_class.c > b/compat/compat_firmware_class.c > index ce937a3..54ee8b9 100644 > --- a/compat/compat_firmware_class.c > +++ b/compat/compat_firmware_class.c > @@ -432,6 +432,8 @@ static int fw_register_device(struct > device **dev_p, const char *fw_name, > dev_set_drvdata(f_dev, fw_priv); > #if (LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,30)) > dev_set_uevent_suppress(f_dev, 1); > +#else > + f_dev->uevent_suppress = 1; > #endif > retval = device_register(f_dev); > if (retval) { > @@ -479,9 +481,11 @@ static int fw_setup_device(struct > firmware *fw, struct device **dev_p, > goto error_unreg; > } > > -#if (LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,30)) > if (uevent) > +#if (LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,30)) > > dev_set_uevent_suppress(f_dev, 0); > +#else > + > f_dev->uevent_suppress = 0; > #endif > *dev_p = f_dev; > goto out; > -- > 1.7.0.2 > > -- > To unsubscribe from this list: send the line "unsubscribe > linux-wireless" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
