Search Linux Wireless

Re: [PATCH] Added configurable debug messages to libertastf

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2010-04-21 at 15:39 -0700, Steve deRosier wrote:
> Add the same type of configurable debug messages to libertas_tf as
> already exist in the libertas driver.  This has facilitated creation of a interface
> specification and will facilitate future development of this driver.
> 
> Signed-off-by: Steve deRosier <steve@xxxxxxxxxxx>
[]
> +#define lbtf_pr_info(format, args...) \
> +	printk(KERN_INFO DRV_NAME": " format, ## args)
> +#define lbtf_pr_err(format, args...) \
> +	printk(KERN_ERR DRV_NAME": " format, ## args)
> +#define lbtf_pr_alert(format, args...) \
> +	printk(KERN_ALERT DRV_NAME": " format, ## args)

I think it'd be better to add

#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

and use the more standard pr_<level>s.

> +#ifdef DEBUG
> +static inline void lbtf_deb_hex(unsigned int grp, const char *prompt, u8 *buf, int len)
> +{
> +	int i = 0;
> +
> +	if (len &&
> +	    (lbtf_debug & LBTF_DEB_HEX) &&
> +	    (lbtf_debug & grp))	{
> +		for (i = 1; i <= len; i++) {
> +			if ((i & 0xf) == 1) {
> +				if (i != 1)
> +					printk("\n");
> +				printk(DRV_NAME " %s: ", prompt);
> +			}
> +			printk("%02x ", (u8) *buf);
> +			buf++;
> +		}
> +		printk("\n");
> +	}
> +}

print_hex_dump_bytes


--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux