On Wed, Apr 21, 2010 at 02:54:57PM -0700, Pavel Roskin wrote: > On Tue, 2010-04-20 at 18:28 -0400, Luis R. Rodriguez wrote: > > This makes ar5416Addac_9160 and ar5416Addac_9160 const > > I guess we skipped them long ago. > > It's a step in the right direction, but it makes the code more > misleading. Those arrays are not constant. > > Please see ath9k_hw_def_set_addac() and ath9k_hw_4k_set_addac(). They > both modify ah->iniAddac for AR9160. > > The compiler doesn't warn about it because the definition of > INIT_INI_ARRAY uses a cast that removes the const modifier. > > It's not an objection against the patch, it's just a reminder that we > have a real problem with the code that is likely to affect parallel > operation of more than one AR9160 device in the system, especially if > they are working on different channels. Yeah good point, well not sure how to resolve that, other than leaving it as is for now. Let me know if you come up with something. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
