On Tuesday 30 March 2010, Gertjan van Wingerde wrote: > On 03/29/10 23:00, Ivo van Doorn wrote: > > On Monday 29 March 2010, Gertjan van Wingerde wrote: > >> On 03/29/10 09:56, Ondrej Zary wrote: > >>> This patch seems to fix random powersaving failure where the device > >>> state is stuck at 1 (STATE_SLEEP) and does not change to 3 > >>> (STATE_AWAKE), resulting in to associate and these error messages: > >>> phy0 -> rt2500usb_set_device_state: Error - Device failed to enter > >>> state 3 (-16). No probe response from AP xx:xx:xx:xx:xx:xx after 500ms, > >>> disconnecting. > >>> > >>> Signed-off-by: Ondrej Zary <linux@xxxxxxxxxxxxxxxxxxxx> > >> > >> Thanks. This looks good, but I'll rehash it against the latest state of > >> affairs of rt2x00, so that the disabling of powersaving is undone at the > >> same time. > >> > >> John, I'll send you the rehashed patch tomorrow. > > > > Is this change interesting for the other drivers as well? > > Anyway, this one gets my Ack: > > > > Acked-By: Ivo van Doorn <IvDoorn@xxxxxxxxx> > > Correct. That is the other reason to rehash. At least rt2400pci and > rt2500pci can use the same change. rt2500pci does not seem to need this change. At least my card never stucks in state 3. But it does in state 3 - this message appears probably on each attempt to enter state 1 (after each packet with "ping" and after terminating "ping -f"): phy0 -> rt2500pci_set_device_state: Error - Device failed to enter state 1 (-16). Otherwise it works fine. Increasing REGISTER_BUSY_COUNT to 20 (and msleep in rt2500pci_set_state() to 30) does not help. -- Ondrej Zary -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
