On Fri, 2010-03-26 at 11:44 +0100, Valentin Longchamp wrote: > An int urb is constructed but we fill it in with a bulk pipe type. > > Commit f661c6f8c67bd55e93348f160d590ff9edf08904 implemented a pipe type > check when CONFIG_USB_DEBUG is enabled. The check failed for all the ar9170 > usb transfers and the driver could not configure the wifi dongle. > > This went unnoticed until now because most people don't have > CONFIG_USB_DEBUG enabled. Actually, if the code was broken and nobody noticed, do we need it at all? ar9170_usb_tx_urb_complete() is an empty function. Suppose we need it, then maybe we could put some debug code there? I think that function has a poor name, it should be something with "cmd", like ar9170_usb_tx_urb_complete_cmd(). By the way, I think such fixes belong to stable. -- Regards, Pavel Roskin -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
