On Fri, 2010-03-26 at 07:21 +0100, ext Johannes Berg wrote: > > > > + NLA_PUT_U32(cqm, NL80211_ATTR_CQM_RSSI_THOLD, thold); > > > > + NLA_PUT_U32(cqm, NL80211_ATTR_CQM_RSSI_HYST, hyst); > > > > > > Hmm. guess I missed that in the kernel side review, but should we change > > > the API so that leaving them out means disabling? > > > > Heh, yep, the kernel part does not disable this if these are left out. > > > > Actually, I can think of one downside to the approach you propose: when > > this gets extended, there will be multiple different cqm parameters, and > > they would have to be always configured simultaneously, otherwise some > > of the configurations would end up disabled. At least with iw, that > > would be somewhat awkward? > > Hmm, yes, maybe. In that case you'd want leaving them out meaning no > change I guess. I'll give it another thought, but now I need to get > sleep and you won't hear from me again until I'm home on like Sunday :) Give it some thought. Currently, leaving them out essentially causes the params to be left unchanged. Obviously, now there is only one trigger, and if you don't configure that the kernel will say -EINVAL. When extended, the -EINVAL will have to be removed anyway. But do have a nice weekend! -Juuso > johannes > > -- > To unsubscribe from this list: send the line "unsubscribe linux-wireless" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
