On Thu, 2010-03-25 at 13:44 -0700, Reinette Chatre wrote: > From: Wey-Yi Guy <wey-yi.w.guy@xxxxxxxxx> > > Use spin_lock_irqsave() in interrupt handler to disable interrupts locally > and provide the spinlock on SMP. This covers both interrupt and SMP > concurrency. > > With this changes, also fix the sparse warning issues. As far as I understand, spin_lock_irqsave() is superfluous in interrupt handlers, since interrupt handlers are run with interrupts disabled. I wonder if you hit the problem that my patch should fix: https://patchwork.kernel.org/patch/84441/ Basically, sparse diagnostics for not fully preemptible SMP kernels is so bogus that it should be ignored completely. -- Regards, Pavel Roskin -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
