Hi Stanislaw, only to clarify: There is no need for "iwlwifi: Silence tfds_in_queue message" patch from wireless-2.6 GIT? I mean "[2.6.32] iwlwifi: fix nfreed--" is enough for solving the mentionned problem? Kind Regards, - Sedat - On Thu, Mar 18, 2010 at 4:11 PM, Adel Gadllah <adel.gadllah@xxxxxxxxx> wrote: > 2010/3/18 Stanislaw Gruszka <sgruszka@xxxxxxxxxx>: >> On Tue, Mar 16, 2010 at 10:00:59AM -0700, reinette chatre wrote: >>> On Sun, 2010-03-14 at 11:44 -0700, Adel Gadllah wrote: >>> > From 83bf3f1dba41e3dccdef4fecfccb094559568342 Mon Sep 17 00:00:00 2001 >>> > From: Adel Gadllah <adel.gadllah@xxxxxxxxx> >>> > Date: Sun, 14 Mar 2010 19:16:25 +0100 >>> > Subject: [PATCH] iwlwifi: Silence tfds_in_queue message >>> > >>> > Commit a239a8b47cc0e5e6d7416a89f340beac06d5edaa introduced a >>> > noisy message, that fills up the log very fast. >>> > >>> > The error seems not to be fatal (the connection is stable and >>> > performance is ok), so make it IWL_DEBUG_TX rather than IWL_ERR. >>> > >>> > Cc: Reinette Chatre <reinette.chatre@xxxxxxxxx> >>> > Cc: John W. Linville <linville@xxxxxxxxxxxxx> >>> > Cc: stable@xxxxxxxxxx >>> > >>> > Signed-off-by: Adel Gadllah <adel.gadllah@xxxxxxxxx> >>> >>> Acked-by: Reinette Chatre <reinette.chatre@xxxxxxxxx> >> >> Actually I would like to NACK the patch. >> >> We did mistake during backporting to 2.6.32 . In iwl_tx_queue_reclaim() >> we make make double nfreed--. I don't know how we miss that :( >> >> Greg please take patch from the next email if Adel conform that >> it fix the issue. > > Yeah not sure that making it a debug message is a bad idea though (but > even if we want that it doesn't matter much for stable). > -- > To unsubscribe from this list: send the line "unsubscribe linux-wireless" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
