On Sat, 13 Mar 2010 01:55:54 -0800 Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> wrote: > Well, right now it is mutex so it will not protect if something happens > in interrupt context. Takeing the global rfkill mutex seems pretty heavy > but there does not seem to be a per-device mutex. There also some > muching with spinlock inside rfkill_set_state but it is dropped when we > actually carry out the operation. I am afraid the locking in rfkill > needs some reviewing... > I _think_ this is ok... as far as i can see everything which writes to rfkill->state in net/rfkill/core.c takes the rfkill->lock spinlock... the mutex probably protects other global rfkill data... as long as drivers only use the rfkill.h interface and not acess the rfkill->state themselves this should be ok... Flo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
