2010/3/9 Bruno Randolf <br1@xxxxxxxxxxx>: > when using a fixed antenna we should use the antenna number in all tx > descriptors, otherwise the hardware will sometimes send the frame out on the > other antenna. it seems like the hardware does not always respect the default > antenna and diversity settings (esp. AR5K_STA_ID1_DEFAULT_ANTENNA). > > also i would like to note that antenna diversity does not always work correctly > on 5414 (at least) when only one antenna is connected: for example all frames > might be received on antenna A but still the HW tries to send on antenna B some > times, causing packet loss. > > this is both verified with the antenna statistics output of the previous patch > and a spectrum analyzer. > > Signed-off-by: Bruno Randolf <br1@xxxxxxxxxxx> > --- > drivers/net/wireless/ath/ath5k/phy.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath5k/phy.c b/drivers/net/wireless/ath/ath5k/phy.c > index 72474c0..ffe253a 100644 > --- a/drivers/net/wireless/ath/ath5k/phy.c > +++ b/drivers/net/wireless/ath/ath5k/phy.c > @@ -1873,7 +1873,7 @@ ath5k_hw_set_antenna_mode(struct ath5k_hw *ah, u8 ant_mode) > break; > case AR5K_ANTMODE_FIXED_A: > def_ant = 1; > - tx_ant = 0; > + tx_ant = 1; > use_def_for_tx = true; > update_def_on_tx = false; > use_def_for_rts = true; > @@ -1882,7 +1882,7 @@ ath5k_hw_set_antenna_mode(struct ath5k_hw *ah, u8 ant_mode) > break; > case AR5K_ANTMODE_FIXED_B: > def_ant = 2; > - tx_ant = 0; > + tx_ant = 2; > use_def_for_tx = true; > update_def_on_tx = false; > use_def_for_rts = true; > > -- > To unsubscribe from this list: send the line "unsubscribe linux-wireless" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > Acked-by: Nick Kossifidis <mickflemm@xxxxxxxxx> -- GPG ID: 0xD21DB2DB As you read this post global entropy rises. Have Fun ;-) Nick -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
