Great, but: On Thu, Mar 4, 2010 at 9:21 AM, Andrew Blaich <ablaich@xxxxxxxxx> wrote: > Updating the patch to include the removal of the define of > AR5K_TUNE_HWTXTRIES per Benoit's suggestion as the patch makes it no > longer necessary. Please repost the patch as a follow-up to the thread, but without the quoted discussion. This allows John to take the email directly once it's ready, without editing the text. You should always write the description as if it were going into the commit log as-is. If you include changelog information (and you should), put it after the '---' with the diffstat. E.g. ath5k: title here. The original description of the brokenness of the tunable here, written as if no one knew about the first patch. Signed-off-by: here --- Anything you want to write can go here, it will get removed by git-am. v2: remove AR5K_TUNE_HWTXTRIES per Benoit's comments [diffstat] --- [patch] > Signed-off-by:: Andrew Blaich <ablaich@xxxxxxxxx> "Signed-off-by:" i.e. one ':' Also you should avoid a lead-in like "This patch" to the extent possible. See: http://userweb.kernel.org/~akpm/stuff/tpp.txt -- Bob Copeland %% www.bobcopeland.com -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
