From: David Miller <davem@xxxxxxxxxxxxx> Date: Thu, 04 Mar 2010 00:41:50 -0800 (PST) > From: Jiri Pirko <jpirko@xxxxxxxxxx> > Date: Wed, 3 Mar 2010 19:09:56 +0100 > >> Here's corrected patch: >> >> Subject: [net-2.6 PATCH] rndis_wlan: correct multicast_list handling V2 >> >> My previous patch (655ffee284dfcf9a24ac0343f3e5ee6db85b85c5) added locking in >> a bad way. Because rndis_set_oid can sleep, there is need to prepare multicast >> addresses into local buffer under netif_addr_lock first, then call >> rndis_set_oid outside. This caused reorganizing of the whole function. >> >> Signed-off-by: Jiri Pirko <jpirko@xxxxxxxxxx> >> Reported-by: Jussi Kivilinna <jussi.kivilinna@xxxxxxxx> > > Applied. Jiri did ou even type make on this patch? The 'size' is still referenced: drivers/net/wireless/rndis_wlan.c: In function 'set_multicast_list': drivers/net/wireless/rndis_wlan.c:1530: error: 'size' undeclared (first use in this function) drivers/net/wireless/rndis_wlan.c:1530: error: (Each undeclared identifier is reported only once drivers/net/wireless/rndis_wlan.c:1530: error: for each function it appears in.) I reverted, and I'm pissed off. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
