Search Linux Wireless

Re: [PATCH] airo : Print of firmware version

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Feb 28, 2010 at 03:42:54PM +0100, matthieu castet wrote:
> For the firmware version 5.30.17 the log file shows:
> Firmware version 5.30.11
>
> The variable softSubVer is binary.
>
>
> Signed-off-by: Matthieu CASTET <castet.matthieu@xxxxxxx>
> Signed-off-by: Jose Alonso <joalonsof@xxxxxxxxx>

> Index: airo.c
> ===================================================================
> --- 1/drivers/net/wireless/airo.c	(r?vision 47)
> +++ 2/drivers/net/wireless/airo.c	(r?vision 48)
> @@ -2993,7 +2993,7 @@
>  	ai->wep_capable = (cap_rid.softCap & cpu_to_le16(0x02)) ? 1 : 0;
>  	ai->max_wep_idx = (cap_rid.softCap & cpu_to_le16(0x80)) ? 3 : 0;
>  
> -	airo_print_info(dev->name, "Firmware version %x.%x.%02x",
> +	airo_print_info(dev->name, "Firmware version %x.%x.%02d",
>  	                ((le16_to_cpu(cap_rid.softVer) >> 8) & 0xF),
>  	                (le16_to_cpu(cap_rid.softVer) & 0xFF),
>  	                le16_to_cpu(cap_rid.softSubVer));

Why should the last segment be in decimal form if the other two
segments of the version number are in hexadecimal form?

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@xxxxxxxxxxxxx			might be all we have.  Be ready.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux