On 02/27/2010 08:52 PM, Ming Lei wrote:
> 2010/2/28 Larry Finger <Larry.Finger@xxxxxxxxxxxx>:
>> On 02/27/2010 10:56 AM, tom.leiming@xxxxxxxxx wrote:
>>> From: Ming Lei <tom.leiming@xxxxxxxxx>
>>>
>>> The patch defines the fields of 'valid_single_stream' and 'valid' in
>>> struct ath_rate_table as char type, so decrease the size of ath9k.ko
>>> about 2KB.
>>>
>>> old ath9k.ko
>>> [tom@tom-lei ath9k]$ size ath9k.ko
>>> text data bss dec hex filename
>>> 69344 3080 168 72592 11b90 ath9k.ko
>>>
>>> new ath9k.ko
>>> [tom@tom-lei ath9k]$ size ath9k.ko
>>> text data bss dec hex filename
>>> 67304 3080 168 70552 11398 ath9k.ko
>>>
>>> Signed-off-by: Ming Lei <tom.leiming@xxxxxxxxx>
>>> ---
>>> drivers/net/wireless/ath/ath9k/rc.h | 4 ++--
>>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/net/wireless/ath/ath9k/rc.h b/drivers/net/wireless/ath/ath9k/rc.h
>>> index 4f6d6fd..389168a 100644
>>> --- a/drivers/net/wireless/ath/ath9k/rc.h
>>> +++ b/drivers/net/wireless/ath/ath9k/rc.h
>>> @@ -110,8 +110,8 @@ struct ath_rate_table {
>>> int rate_cnt;
>>> int mcs_start;
>>> struct {
>>> - int valid;
>>> - int valid_single_stream;
>>> + char valid;
>>> + char valid_single_stream;
>>> u8 phy;
>>> u32 ratekbps;
>>> u32 user_ratekbps;
>>
>> Why 'char' rather than 'u8'? To me, the latter implies a small integer, not
>> character data.
>
> Either 'char' or 'u8' is OK, since both has one-byte size, isn't it?
It wasn't the size, but the content implied by the type.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
