Search Linux Wireless

Re: [PATCH] ath9k_htc: Add ath9k_htc driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Pavel Roskin wrote:
> > @@ -1240,7 +1228,7 @@ void ath9k_hw_deinit(struct ath_hw *ah)
> >  {
> >       struct ath_common *common = ath9k_hw_common(ah);
> >
> > -     if (common->state <= ATH_HW_INITIALIZED)
> > +     if (common->state < ATH_HW_INITIALIZED)
> >               goto free_hw;
> >
> >       if (!AR_SREV_9100(ah))
> 
> There are some non-trivial parts like this one that could be submitted
> separately.
> 
> > @@ -1249,10 +1237,8 @@ void ath9k_hw_deinit(struct ath_hw *ah)
> >       ath9k_hw_setpower(ah, ATH9K_PM_FULL_SLEEP);
> >
> >  free_hw:
> > -     if (!AR_SREV_9280_10_OR_LATER(ah))
> > +     if (!AR_SREV_9280_10_OR_LATER(ah) && !AR_SREV_9271(ah))
> >               ath9k_hw_rf_free_ext_banks(ah);
> > -     kfree(ah);
> > -     ah = NULL;
> 
> Another one.  Actually, it is trivial, but not ath9k_htc related.
> 
> It would be really nice to fast track the ath9k_htc driver to 2.6.34,
> but the changes affecting other devices should be separate, I believe.

I'll submit this fix as a separate patch.

Sujith
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux