Hello!
I have tested both patches on the real hardware, and I don't see any
regressions. Unfortunately, the issue with interrupts is still there,
so ping stops after 11 packets, which limited my ability to test the
change extensively. That said, I was able to use wpa_supplicant and
dhcp to get an IP address using the patched driver in the station mode.
wpa_supplicant worked most of the time. I believe the occasional
failures are due to a preexisting memory corruption issue (I reported
earlier that addr3 can be corrupted in probe requests).
Unfortunately, the patches include corrupt whitespace, so they had to be
applied by "patch -l". Also, there are trailing tabs in two places.
That's not a big deal, but it's better avoided. Please consider using
git or stgit to send patches.
> + for (i=0; i<256; i++) {
checkpatch.pl complains about spacing. There should be spaces around
"=" and "<"
> + txwi = (__le32 *)(entry->skb->data -
> + rt2x00dev->hw->extra_tx_headroom);
I really don't see any point in introducing wrong code in one patch and
fixing it in another. I would just join the patches.
When bisecting for a problem, landing at a broken commit can lead to a
lot of wasted time.
> + rt2x00_desc_read(txwi, 1, &word);
> + tx_wcid = rt2x00_get_field32(word, TXWI_W1_WIRELESS_CLI_ID);
> + tx_ack = rt2x00_get_field32(word, TXWI_W1_ACK);
> + tx_pid = rt2x00_get_field32(word, TXWI_W1_PACKETID);
> +
> + if ((wcid != tx_wcid) || (ack != tx_ack) || (pid != tx_pid))
> + WARNING(rt2x00dev, "invalid TX_STA_FIFO content\n");
Can we make this sanity check optional?
--
Regards,
Pavel Roskin
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
