Search Linux Wireless

Re: [PATCH 15/22] wl1271: Aggregate RX acknowledgements to FW

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2010-02-22 at 09:35 +0100, ext Johannes Berg wrote:
> On Mon, 2010-02-22 at 08:38 +0200, Juuso Oikarinen wrote:
> 
> > 		wl->rx_counter++;
> >  		drv_rx_counter = wl->rx_counter & NUM_RX_PKT_DESC_MOD_MASK;
> > -		wl1271_write32(wl, RX_DRIVER_COUNTER_ADDRESS, wl->rx_counter);
> >  	}
> > +
> > +	wl1271_write32(wl, RX_DRIVER_COUNTER_ADDRESS, wl->rx_counter);
> >  }
> 
> What if the counter overflows and you got the & to change it?
> 
> johannes
> 

The rx_counter itself is never changed with & - it's just incremented
for each frame. It's supposed to overflow when the u32 is full - it will
then still behave sane when a delta is calculated inside the firmware
against its corresponding counter. That's a very common way to handle
counters for this particular chipset.

Did I miss the point?

-Juuso


--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux