On Tue, Feb 16, 2010 at 12:05:25PM -0800, Luis R. Rodriguez wrote: > On Sun, Feb 14, 2010 at 3:18 PM, Andres Salomon > <dilinger@xxxxxxxxxxxxxxx> wrote: > > On Mon, 8 Feb 2010 10:32:50 -0800 > > "Luis R. Rodriguez" <mcgrof@xxxxxxxxx> wrote: > > > >> On Sun, Feb 7, 2010 at 6:48 PM, Andres Salomon > >> <dilinger@xxxxxxxxxxxxxxx> wrote: > >> > > >> > I discovered that if EMBEDDED=y, one can accidentally build a > >> > mac80211 stack w/ no rate control algorithm. When RC_MINISTREL and > >> > RC_PID are both disabled, the RC_DEFAULT string (which rate.c uses > >> > as the fallback algorithm) will be "". That'll cause the > >> > rate_control_alloc to fail, which will in turn cause > >> > ieee80211_register_hw to fail. IOW, no driver will load. > >> > > >> > This will tell kconfig to provide a warning if no rate control > >> > algorithms have been selected. That'll at least warn the user that > >> > they're about to build a broken wireless stack. > >> > >> > >> Please Cc: stable@xxxxxxxxxx here as well, I think we've had this for > >> a while. > >> > >> > Signed-off-by: Andres Salomon <dilinger@xxxxxxxxxxxxxxx> > >> > >> Luis > > > > Here's an updated patch. I ended up just changing the wording. > > > > > > > > > > Subject: [PATCH] mac80211: give warning if building w/out rate ctrl algorithm > > > > I discovered that if EMBEDDED=y, one can accidentally build a mac80211 stack > > and drivers w/ no rate control algorithm. For drivers like RTL8187 that don't > > supply their own RC algorithms, this will cause ieee80211_register_hw to > > fail (making the driver unusable). > > > > This will tell kconfig to provide a warning if no rate control algorithms > > have been selected. That'll at least warn the user; users that know that > > their drivers supply a rate control algorithm can safely ignore the > > warning, and those who don't know (or who expect to be using multiple > > drivers) can select a default RC algorithm. > > > > Signed-off-by: Andres Salomon <dilinger@xxxxxxxxxxxxxxx> > > You want to add Cc: stable@xxxxxxxxxx on the commit log, not on the e-mail. And repost the patch in a separate email, not in a reply that I have to munge before I can feed it to git... John -- John W. Linville Someday the world will need a hero, and you linville@xxxxxxxxxxxxx might be all we have. Be ready. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
