Johannes Berg a écrit :
On Mon, 2010-02-15 at 08:45 +0100, Benoit PAPILLAULT wrote:
I'm not familiar with this part of the code; but have you tested if
this doesn't break monitor-while-operating mode (i.e. doesn't remove
other-STA frames from monitor interfaces)?
Yes, it has been tested in this case. In fact, this patch changes RX
path only in ieee80211_rx_h_data / ieee80211_rx_h_action and
ieee80211_rx_h_mgmt. In all 3 cases, it returns RX_DROP_MONITOR.
???
if (ieee80211_drop_unencrypted(rx, mgmt->frame_control))
return RX_DROP_UNUSABLE;
This code was not in wireless-testing/master yesterday when I sent the
patches.
However. GUYS!!! Read the code! Real monitor mode bypasses _ALL_ the RX
handlers, frames just short-circuit up right after they are received
from the driver.
Just for my own understanding. It seems the implementation has 2
different code path :
- "real" monitor mode which is handled right after ieee80211_rx() so it
is not affected
- "cook" monitor mode which is handled as part of the RX handlers.
BTW, why do we have 2 different code path? I'm sure I missed something
obvious here.
johannes
Regards,
Benoit
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
