Search Linux Wireless

Re: [PATCH 2/2] mac80211: Fix WPA-NONE for RX unicast frames

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2010-02-15 at 00:32 +0100, Benoit Papillault wrote:
> This patch might have side effect which needs to be studied
> 
> Signed-off-by: Benoit Papillault <benoit.papillault@xxxxxxx>
> ---
>  net/mac80211/rx.c |    8 ++++++++
>  1 files changed, 8 insertions(+), 0 deletions(-)
> 
> diff --git a/net/mac80211/rx.c b/net/mac80211/rx.c
> index 22ae6ee..f73fe9b 100644
> --- a/net/mac80211/rx.c
> +++ b/net/mac80211/rx.c
> @@ -923,6 +923,13 @@ ieee80211_rx_h_decrypt(struct ieee80211_rx_data
> *rx)
>  		rx->key = rcu_dereference(rx->sdata->keys[keyidx]);
>  
>  		/*
> +		 * Using WPA-NONE in IBSS, all frames, be it unicast or
> +		 * multicast (including broadcast) are encrypted with the
> +		 * same group key. In this case, we should not reset the key
> +		 * to NULL
> +		 */
> +#if 0
> +		/*
>  		 * RSNA-protected unicast frames should always be sent with
>  		 * pairwise or station-to-station keys, but for WEP we allow
>  		 * using a key index as well.

#if 0 is never a good idea, and that code is certainly needed.

Don't send bad patches like this with [PATCH] tag please.

johannes

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux