Okay, ACK. -- Ben -- >-----Original Message----- >From: Guy, Wey-Yi W >Sent: Thursday, February 11, 2010 3:23 PM >To: Cahill, Ben M >Cc: Chatre, Reinette; linville@xxxxxxxxxxxxx; >linux-wireless@xxxxxxxxxxxxxxx; ipw3945-devel@xxxxxxxxxxxxxxxxxxxxx >Subject: RE: [ipw3945-devel] [PATCH 05/12] iwlwifi: remove >unused op-code in PHY Calibration command > >Hi Ben, > >this is per Giora's request to remove unused calibration command. so we >will not alarm external to play with those commands. > >we can add those back in if we are going to use it. > >Wey > >On Thu, 2010-02-11 at 12:17 -0800, Cahill, Ben M wrote: >> NACK. Keep them around; we may use in the future. >> >> -- Ben -- >> >> >-----Original Message----- >> >From: Reinette Chatre [mailto:reinette.chatre@xxxxxxxxx] >> >Sent: Thursday, February 11, 2010 1:42 PM >> >To: linville@xxxxxxxxxxxxx >> >Cc: Chatre, Reinette; linux-wireless@xxxxxxxxxxxxxxx; >> >ipw3945-devel@xxxxxxxxxxxxxxxxxxxxx >> >Subject: [ipw3945-devel] [PATCH 05/12] iwlwifi: remove unused >> >op-code in PHY Calibration command >> > >> >From: Wey-Yi Guy <wey-yi.w.guy@xxxxxxxxx> >> > >> >Number of calibration op-code are not used by driver, >remove those from >> >iwl-commands.h >> > >> >Signed-off-by: Wey-Yi Guy <wey-yi.w.guy@xxxxxxxxx> >> >Signed-off-by: Reinette Chatre <reinette.chatre@xxxxxxxxx> >> >--- >> > drivers/net/wireless/iwlwifi/iwl-commands.h | 4 ---- >> > 1 files changed, 0 insertions(+), 4 deletions(-) >> > >> >diff --git a/drivers/net/wireless/iwlwifi/iwl-commands.h >> >b/drivers/net/wireless/iwlwifi/iwl-commands.h >> >index c2f31eb..ab3c77b 100644 >> >--- a/drivers/net/wireless/iwlwifi/iwl-commands.h >> >+++ b/drivers/net/wireless/iwlwifi/iwl-commands.h >> >@@ -3470,11 +3470,7 @@ enum { >> > IWL_PHY_CALIBRATE_DIFF_GAIN_CMD = 7, >> > IWL_PHY_CALIBRATE_DC_CMD = 8, >> > IWL_PHY_CALIBRATE_LO_CMD = 9, >> >- IWL_PHY_CALIBRATE_RX_BB_CMD = 10, >> > IWL_PHY_CALIBRATE_TX_IQ_CMD = 11, >> >- IWL_PHY_CALIBRATE_RX_IQ_CMD = 12, >> >- IWL_PHY_CALIBRATION_NOISE_CMD = 13, >> >- IWL_PHY_CALIBRATE_AGC_TABLE_CMD = 14, >> > IWL_PHY_CALIBRATE_CRYSTAL_FRQ_CMD = 15, >> > IWL_PHY_CALIBRATE_BASE_BAND_CMD = 16, >> > IWL_PHY_CALIBRATE_TX_IQ_PERD_CMD = 17, >> >-- >> >1.6.3.3 >> > >> > >> >--------------------------------------------------------------- >> >--------------- >> >SOLARIS 10 is the OS for Data Centers - provides features such >> >as DTrace, >> >Predictive Self Healing and Award Winning ZFS. Get Solaris 10 NOW >> >http://p.sf.net/sfu/solaris-dev2dev >> >_______________________________________________ >> >Ipw3945-devel mailing list >> >Ipw3945-devel@xxxxxxxxxxxxxxxxxxxxx >> >https://lists.sourceforge.net/lists/listinfo/ipw3945-devel >> >-- >> To unsubscribe from this list: send the line "unsubscribe >linux-wireless" in >> the body of a message to majordomo@xxxxxxxxxxxxxxx >> More majordomo info at http://vger.kernel.org/majordomo-info.html > >-- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
