On Tue, Feb 9, 2010 at 1:27 PM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote:
> On Mon, 2010-02-08 at 17:47 +0530, Vivek Natarajan wrote:
>> + if (ieee80211_is_nullfunc(fc) && ieee80211_has_pm(fc) &&
>> + (local->hw.flags & IEEE80211_HW_TX_STATUS) &&
>> + local->ps_sdata && !(local->scanning)) {
>> + if (info->flags & IEEE80211_TX_STAT_ACK) {
>> + local->ps_sdata->u.mgd.flags |=
>> + IEEE80211_STA_NULLFUNC_ACKED;
>> + ieee80211_queue_work(&local->hw,
>> + &local->dynamic_ps_enable_work);
>> + } else
>> + mod_timer(&local->dynamic_ps_timer, jiffies +
>> + msecs_to_jiffies(10));
>> + }
>
> I think this needs to check against injected frames as well
Any monitor mode injected frame should be dropped by the
check of ps_sdata which is set only during the station mode.
> personally, I'd prefer if you only indented the stuff belonging into the
> first if by 4 spaces to match up with the "if ("].
Thanks. I will modify it.
> Also, you're still missing documentation on IEEE80211_HW_TX_STATUS.
I think you missed the v4 with the name changed as
IEEE80211_HW_REPORTS_TX_ACK_STATUS.
I will send it once again with modified indentation.
Thanks
Vivek.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
