On Monday 08 February 2010 21:30:09 Christian Lamparter wrote: > On Monday 08 February 2010 17:24:39 Johannes Berg wrote: > > On Mon, 2010-02-08 at 18:43 +0530, Vivek Natarajan wrote: > > > > > > On a related issue: What about _inverting_ the flag, so it will > > > > be set for devices which can't give any accurate tx_status > > > > information. This has the advantage that we don't have to touch > > > > other drivers? > > > > > > Shall I rename it as HW_NO_TX_ACK_REPORT? > > > Looking at the other flags, they show some positively present > > > feature in the hw. In those lines, HW_REPORTS_TX_ACK_STATUS > > > might be better. > > > > The positive feature flag has the advantage that we don't have to touch > > any of the essentially unmaintained drivers, so I much prefer having it > > that way so maintainers can enable the flag after testing etc. > > BTW: I added rt2x00 project maintainers to the CC, because > If I'm not totally wrong, this patch _reduces_ some PS > features of rt2x00. This is because not all of rt2x00 > supported & PS-capable/enabled devices return a proper tx_status > and therefore these devices will be the most affected AFAICT. > > Any word from you guys? Or have you scrubbed the PS features already? > Oops, Johannes pointed out that the patch does not break rt2x00. and indeed ... he IS right and I misread the check !HW_STATUS_CHECK in ieee80211_enable_ps. Sorry for all the noise! -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
