On Mon, 08 Feb 2010 10:06:33 +0100 Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Sun, 2010-02-07 at 21:48 -0500, Andres Salomon wrote: > > I discovered that if EMBEDDED=y, one can accidentally build a > > mac80211 stack w/ no rate control algorithm. When RC_MINISTREL and > > RC_PID are both disabled, the RC_DEFAULT string (which rate.c uses > > as the fallback algorithm) will be "". That'll cause the > > rate_control_alloc to fail, which will in turn cause > > ieee80211_register_hw to fail. IOW, no driver will load. > > > > This will tell kconfig to provide a warning if no rate control > > algorithms have been selected. That'll at least warn the user that > > they're about to build a broken wireless stack. > > > > +comment "mac80211 will not work properly w/out rate control > > algorithm" > > + depends on MAC80211_HAS_RC=n > > Except that isn't true for hardware that doesn't require an algorithm, > or drivers that provide it themselves, like iwlagn or ath9k. I would > prefer it to be worded accordingly. > Noted. I was wondering if there were any. How about having drivers that need them depend upon MAC80211_HAS_RC or some such, and having the text say something like "most drivers require rate control"?
Attachment:
signature.asc
Description: PGP signature
