Search Linux Wireless

Re: [RFC 1/2] cfg80211: generic trigger scan and callback on completion

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 2010-02-06 at 13:20 +0000, David Kilroy wrote:

> We could maintain a list of functions to call, but this isn't necessary
> for the moment. Just maintain the single function pointer to be called
> on scan completion.
> 
> Note that we allow the caller to set the callback even when a scan is
> already in progress. This allows cfg80211 SME to scan again
> when the existing scan completes.

I think the "callback even when busy" thing is somewhat confusing. I'd
prefer if you used a standard notifier struct (probably raw since we
have rdev locking; see include/linux/notifier.h) and the callees sorted
out their state there. As it is, it's really complicated to make sure
that one request doesn't clobber another -- the current use guarantees
that but I'm not sure I want to rely on it going forward.

johannes

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux