On 02/05/2010 10:27 AM, Gábor Stefanik wrote: > On Fri, Feb 5, 2010 at 4:24 AM, Larry Finger <Larry.Finger@xxxxxxxxxxxx> wrote: >> On 02/04/2010 02:57 PM, Rafał Miłecki wrote: >>> --- >>> Gábor: I think you missed specs here. Could you check whole routine just for >>> sure, please? I don't understand whole radio and chanspec magic yet. >>> --- >>> drivers/net/wireless/b43/phy_lp.c | 2 +- >>> 1 files changed, 1 insertions(+), 1 deletions(-) >>> >>> diff --git a/drivers/net/wireless/b43/phy_lp.c b/drivers/net/wireless/b43/phy_lp.c >>> index 185219e..61009ee 100644 >>> --- a/drivers/net/wireless/b43/phy_lp.c >>> +++ b/drivers/net/wireless/b43/phy_lp.c >>> @@ -2655,8 +2655,8 @@ static int b43_lpphy_op_switch_channel(struct b43_wldev *dev, >>> if (err) >>> return err; >>> lpphy_set_analog_filter(dev, new_channel); >>> - lpphy_adjust_gain_table(dev, channel2freq_lp(new_channel)); >>> } >>> + lpphy_adjust_gain_table(dev, channel2freq_lp(new_channel)); >>> >>> lpphy->channel = new_channel; >>> b43_write16(dev, B43_MMIO_CHANNEL, new_channel); >> >> Both the lpphy_set_analog_filter() and lpphy_adjust_gain_table() calls should be >> outside the if statement. I changed the spec a little. It used to test "radio >> enabled", but I have found that is always true for our driver. >> >> Larry >> >> > > Isn't set_analog_filter() rev0/1-specific? The new routines are described in http://bcm-v4.sipsolutions.net/802.11/PHY/LP/TxFilterInit http://bcm-v4.sipsolutions.net/802.11/PHY/LP/TxDigFiltUcodeRev2 The revised routines are: http://bcm-v4.sipsolutions.net/802.11/PHY/LP/SetChanSpecLPPHY http://bcm-v4.sipsolutions.net/802.11/PHY/LP/PR41573 Larry -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
