Vivek Natarajan <vivek.natraj@xxxxxxxxx> writes: >>> + if ((local->hw.flags & IEEE80211_HW_NEEDS_RX_PS_RESET) && >>> + ieee80211_is_data(hdr->frame_control) && >>> + !is_multicast_ether_addr(hdr->addr1)) { >>> + if (local->hw.conf.dynamic_ps_timeout > 0 && local->ps_sdata) { >>> + mod_timer(&local->dynamic_ps_timer, jiffies + >>> + msecs_to_jiffies(local->hw.conf.dynamic_ps_timeout)); >>> + } >>> + } >> >> What if CONF_PS is set? You need to take that into account here and >> disable powersave when it's enabled. > > With ath9k, for a data frame(non-multicast) to reach mac80211, > CONF_PS should have been disabled. in other words,a data packet will > not reach mac80211 when CONF_PS is set. Hence that check might be > redundant here. I checked this now, and that indeed is the case. So no need to check CONF_PS here. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html