Search Linux Wireless

Re: [RFC PATCH 2/2] mac80211: Reset dynamic ps timer in Rx path.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2010-02-04 at 12:24 +0530, Vivek Natarajan wrote:
> If there is a continuous Rx UDP traffic with power save enabled,
> there is some loss of packets with ath9k as Atheros chipsets
> need to be awake to do Rx, unlike other vendor chipsets.

That sentence doesn't make a whole lot of sense, all chips need to be
awake to RX ;)

IOW, I think the flag is probably useless?

> +	if ((local->hw.flags & IEEE80211_HW_NEEDS_RX_PS_RESET) &&
> +	    ieee80211_is_data(hdr->frame_control) &&
> +	    !is_multicast_ether_addr(hdr->addr1)) {
> +		if (local->hw.conf.dynamic_ps_timeout > 0 && local->ps_sdata) {

Why nest two if statements instead of just using a single one?

johannes

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux