Good point, thanks
On Tue, 2010-02-02 at 17:09 -0800, Christian Lamparter wrote:
> On Wednesday 03 February 2010 01:52:50 wey-yi.w.guy@xxxxxxxxx wrote:
> > From: Wey-Yi Guy <wey-yi.w.guy@xxxxxxxxx>
> >
> > When there is a need to restart/reconfig hw, tear down all the
> > aggregation queues and let the mac80211 and driver get in-sync and have
> > the opportunity to re-establish the aggregation queues.
> >
> > Signed-off-by: Wey-Yi Guy <wey-yi.w.guy@xxxxxxxxx>
> > ---
> > net/mac80211/util.c | 5 +++++
> > 1 files changed, 5 insertions(+), 0 deletions(-)
> >
> > diff --git a/net/mac80211/util.c b/net/mac80211/util.c
> > index ca170b4..6116ad0 100644
> > --- a/net/mac80211/util.c
> > +++ b/net/mac80211/util.c
> > @@ -1188,6 +1188,11 @@ int ieee80211_reconfig(struct ieee80211_local *local)
> > ieee80211_wake_queues_by_reason(hw,
> > IEEE80211_QUEUE_STOP_REASON_SUSPEND);
> >
> > + if (hw->flags & IEEE80211_HW_AMPDU_AGGREGATION) {
> > + list_for_each_entry_rcu(sta, &local->sta_list, list) {
> > + ieee80211_sta_tear_down_BA_sessions(sta);
> > + }
> > + }
> hmm, I somehow miss the rcu_read_lock(); and rcu_read_unlock(); around
> list_for_each_entry_rcu... Are you really sure that you don't need
> them?
>
> Regards,
> Chr
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
