On Mon, Feb 1, 2010 at 12:36 PM, John W. Linville <linville@xxxxxxxxxxxxx> wrote: > On Mon, Feb 01, 2010 at 10:11:54AM -0800, Luis R. Rodriguez wrote: >> On Sat, Jan 30, 2010 at 6:37 PM, Pavel Roskin <proski@xxxxxxx> wrote: >> > Calling ath_bus_cleanup() after ieee80211_free_hw() resulted in access >> > to common->bus_ops, which is already freed as part of the device data. >> > >> > Remove the cleanup field in struct ath_bus_ops, as it was never used >> > properly. Remove ath_bus_cleanup(). Merge cleanup functions in place >> > of the ath_bus_cleanup() calls. Take care not to use any device data >> > after ieee80211_free_hw(). >> > >> > Signed-off-by: Pavel Roskin <proski@xxxxxxx> >> > --- >> > >> > The bug was causing a hang on a kernel with most debugging options >> > enabled. I think the fix is important and simple enough for stable >> > kernels. I wish I could make the patch smaller, but I didn't want to >> > leave unused and dangerous fields and functions. >> > >> > ath9k was tested on the PCI bus. ath9k on AHB was compile tested. >> > ath5k and ar9170 use struct ath_bus_ops, but don't use the cleanup >> > field, so they are not affected. >> >> Thanks, can you please resend with a Cc: stable@xxxxxxxxxx on the commit log? > > Doesn't look to me like the patch even applies to 2.6.33...? Sorry thought it would have by then. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html