Search Linux Wireless

RE: [PATCH 1/1] cfg80211: wext: set bssid to NULL in SIOCIWESSID

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Actually I don't think my patch disables that functionality. If there're multiple AP with the same essid "foo" and one of them has MAC "00:...:ff", then:

iwconfig wlan0 essid "foo"
This will make the station associate with the first AP with essid "foo".

iwconfig wlan0 ap "00:...:ff"
This will disassociate from the previous AP, and then associate with the first AP with MAC "00:...:ff".

Am I missing anything here?

Thanks,
Shanyu

-----Original Message-----
From: Johannes Berg [mailto:johannes@xxxxxxxxxxxxxxxx] 
Sent: Saturday, January 30, 2010 12:37 AM
To: Zhao, Shanyu
Cc: linux-wireless@xxxxxxxxxxxxxxx
Subject: Re: [PATCH 1/1] cfg80211: wext: set bssid to NULL in SIOCIWESSID

On Fri, 2010-01-29 at 15:39 -0800, shanyu.zhao@xxxxxxxxx wrote:
> From: Shanyu Zhao <shanyu.zhao@xxxxxxxxx>
> 
> Need to set bssid to NULL in cfg80211's SIOCIWESSID function, otherwise
> after "iwconfig wlanx ap <mac>", the "iwconfig wlanx essid" won't work.
> 
> Cc: stable@xxxxxxxxxx
> 
> Signed-off-by: Shanyu Zhao <shanyu.zhao@xxxxxxxxx>
> ---
>  net/wireless/wext-sme.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/net/wireless/wext-sme.c b/net/wireless/wext-sme.c
> index eede356..5a67dd5 100644
> --- a/net/wireless/wext-sme.c
> +++ b/net/wireless/wext-sme.c
> @@ -194,6 +194,7 @@ int cfg80211_mgd_wext_siwessid(struct net_device *dev,
>  	wdev->wext.connect.ssid = wdev->wext.ssid;
>  	memcpy(wdev->wext.ssid, ssid, len);
>  	wdev->wext.connect.ssid_len = len;
> +	wdev->wext.connect.bssid = NULL;

This is incorrect. If you want to connect to an AP with the SSID "foo"
and the BSSID "00:...:ff" you need to make two calls, e.g.

iwconfig wlan0 essid "foo"
iwconfig wlan0 ap "00:...:ff"

Your patch disables that functionality.

johannes
��.n��������+%������w��{.n�����{���zW����ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux