On Wed, Jan 27, 2010 at 10:04 AM, Guy, Wey-Yi <wey-yi.w.guy@xxxxxxxxx> wrote: > On Wed, 2010-01-27 at 10:01 -0800, Luis R. Rodriguez wrote: >> On Tue, Jan 26, 2010 at 5:19 AM, Johannes Berg >> <johannes@xxxxxxxxxxxxxxxx> wrote: >> > Because DTIM information is required for powersave >> > but is only conveyed in beacons, wait for a beacon >> > before enabling powersave, and change the way the >> > information is conveyed to the driver accordingly. >> > >> > mwl8k doesn't currently seem to implement PS but >> > requires the DTIM period in a different way; after >> > talking to Lennert we agreed to just have mwl8k do >> > the parsing itself in the finalize_join work. >> >> Not sure if this is merged yet. If not it might be good to add to the >> commit log a brief about the impact of the fix for distribution >> purposes looking to cherry pick some fixes that may cure some issues. >> >> The impact of this fix is that the DTIM settings of > 1 would now be >> respected in the odd situation a beacon would not be received prior to >> association. Ensuring we use a higher DTIM would mean saving more >> power as it would mean we can sleep longer. >> >> This is not propagated to stable but if it turns out this can enhance >> power save since DTIM might usually be > 1 and the race may be more >> common than we expected we may need a respective stable solution. >> > > It will be nice to see a respective solution for stable since this > impact power save which is very important for certain platform. Well how about your patch for stable then? Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html