2010/1/27 John W. Linville <linville@xxxxxxxxxxxxx>:
> On Tue, Jan 26, 2010 at 11:53:38PM +0100, Gábor Stefanik wrote:
>> On Tue, Jan 26, 2010 at 10:22 PM, John W. Linville
>> <linville@xxxxxxxxxxxxx> wrote:
>> > Signed-off-by: John W. Linville <linville@xxxxxxxxxxxxx>
>> > ---
>> > drivers/net/wireless/rtl818x/rtl8180_dev.c | 15 +++++++++++++++
>> > 1 files changed, 15 insertions(+), 0 deletions(-)
>> >
>> > diff --git a/drivers/net/wireless/rtl818x/rtl8180_dev.c b/drivers/net/wireless/rtl818x/rtl8180_dev.c
>> > index 5a2b719..8dbb504 100644
>> > --- a/drivers/net/wireless/rtl818x/rtl8180_dev.c
>> > +++ b/drivers/net/wireless/rtl818x/rtl8180_dev.c
>> > @@ -761,6 +761,20 @@ static void rtl8180_configure_filter(struct ieee80211_hw *dev,
>> > rtl818x_iowrite32(priv, &priv->map->RX_CONF, priv->rx_conf);
>> > }
>> >
>> > +static u64 rtl8180_get_tsf(struct ieee80211_hw *dev)
>> > +{
>> > + struct rtl8180_priv *priv = dev->priv;
>> > + u32 tsftl;
>> > + u64 tsft;
>> > +
>> > + tsftl = rtl818x_ioread32(priv, &priv->map->TSFT[0]);
>> > + tsft = rtl818x_ioread32(priv, &priv->map->TSFT[1]);
>> > + tsft <<= 32;
>> > + tsft |= tsftl;
>> > +
>> > + return tsft;
>> > +}
>>
>> Why not:
>>
>> struct rtl8180_priv *priv = dev->priv;
>> u64 tsft;
>>
>> tsft = rtl818x_ioread32(priv, &priv->map->TSFT[0]);
>> tfst |= rtl818x_ioread32(priv, &priv->map->TSFT[1]) << 32;
>>
>> return tsft;
>
> What difference does it make?
>
> John
The primary difference is that it is significantly shorter, and gets
away without a temp variable.
(This is like writing
driver_write32(dev, reg, driver_read32(dev, reg) | 0x80);
instead of
tmp = driver_read32(dev, reg);
tmp |= 0x80;
driver_write32(dev, reg, tmp);
Saves some code.)
> --
> John W. Linville Someday the world will need a hero, and you
> linville@xxxxxxxxxxxxx might be all we have. Be ready.
>
--
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
