On Saturday 23 January 2010 19:34:19 Larry Finger wrote: > On 01/23/2010 12:19 PM, Michael Buesch wrote: > > On Saturday 23 January 2010 18:47:42 Johannes Berg wrote: > >> > >> I think this might be because update_tkip_key is called from within the > >> RX path, so it's probably not even safe to use mutexes to start with? > > > > Well, if mac80211 does a callback into the driver on behalf of a driver call, > > that is broken design. It would break for all locks, not just mutexes. > > We should probably switch back to ieee80211_rx_irqsafe to workaround these > > circular locking problems. > > Michael, I'll let you fix this. I do confirm that the mutex is locked when the > update_tkip_key callback is invoked. > > Was this problem introduced with the switch to interrupt threads? If so, then > the fix needs to be applied to 2.6.32 and 2.6.33. Well, not really. It was a separate patch that converted ieee80211_rx_irqsafe to ieee80211_rx and a later patch changed that to ieee80211_rx_ni. -- Greetings, Michael. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
