On Fri, 2010-01-22 at 09:14 -0500, pat-lkml@xxxxxxxxx wrote: > On Fri, 22 Jan 2010 10:34:38 +0100, Johannes Berg > <johannes@xxxxxxxxxxxxxxxx> wrote: > > On Thu, 2010-01-21 at 18:06 -0500, Luis R. Rodriguez wrote: > > > >> +#if (LINUX_VERSION_CODE < KERNEL_VERSION(2,6,23)) > >> +static bool ieee80211_all_queues_stopped(struct ieee80211_hw *hw) > > > > You want "all queues started" :) > > > Are you certain of this? I stared and stared trying to see what case > the function would behave as a "started" check. It loops through all > queues, returning false if it finds any started queues. If it makes > it through all the queues and hasn't found a single started queue, it > returns true (to indicate all queues are stopped). > > Or do you mean, as a second function? No, I mean instead. The function is named correctly for what it does, but it does the wrong thing for the logic where it is used. johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
