Hi On Thu, Jan 21, 2010 at 10:02:24AM -0800, reinette chatre wrote: > The 2.6.32 and 2.6.31 code you are changing here adds a device "power > up" call into iwl_eeprom_init. This is not necessary since as you can > see, in iwl3945_pci_probe this exact same call is made right before > iwl_eeprom_init is called. Sorry, missed that. I should wrote in the changelog that this is backport of more commits and remove power up stuff from pci proble as well. > > > > On 2.6.31 and 2.6.32 iwl3945 crash during kdump, I discovered > > above upstream commit fix that. > > This does not make sense. Was this testing done in the stable kernel > from linux-2.6-stable or perhaps a kernel that had those other power > saving patches backported? I tested backported patch on 2.6.32.4. It fix kdump, this issue is 100% reproducible on my laptop with iwl3945. The functional change introduced in this patch is we disable device after EEPROM read. I think that make difference with kdump. Not sure if this right fix or just workaround. Debugging kdump kernel is somehow limited, I have no netconsole or serial console option. I can only see last part of call trace where are iwlwifi functions. I'm going dig into kernel to make calltrace shorter and see where exact the oops is. Cheers Stanislaw -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
