W dniu 17 stycznia 2010 23:45 użytkownik Michael Buesch <mb@xxxxxxxxx> napisał:
> On Sunday 17 January 2010 23:37:50 Rafał Miłecki wrote:
>> @@ -1895,14 +1880,12 @@ static int b43_nphy_cal_tx_iq_lo(struct b43_wldev *dev,
>> b43_phy_write(dev, B43_NPHY_IQLOCAL_CMDNNUM, tmp);
>>
>> if (type == 1 || type == 3 || type == 4) {
>> - /* TODO: Read an N PHY Table with ID 15,
>> - length 1, offset 69 + core,
>> - width 16, and data pointer buffer */
>> + b43_ntab_write(dev, B43_NTAB16(15, 69 + core),
>> + buffer[0]);
>> diq_start = buffer[0];
>> buffer[0] = 0;
>> - /* TODO: Write an N PHY Table with ID 15,
>> - length 1, offset 69 + core, width 16,
>> - and data of 0 */
>> + b43_ntab_write(dev, B43_NTAB16(15, 69 + core),
>> + 0);
>> }
>>
>> b43_phy_write(dev, B43_NPHY_IQLOCAL_CMD, cmd);
>
> What is this supposed to do? It writes a value to a table entry and immediately
> clobbers the entry with 0. This doesn't make any sense.
Yaiks, you're great at patches reviewing. Thanks once more.
For explanation of my stupid mistake please compare removed comment to
added code...
--
Rafał
��.n��������+%������w��{.n�����{���zW����ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
