Search Linux Wireless

Re: [PATCH] mac80211: fix memory leak in ieee80211_send_probe_req

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Kalle Valo <kalle.valo@xxxxxx> writes:

> "ext tom.leiming@xxxxxxxxx" <tom.leiming@xxxxxxxxx> writes:
>
>> From: Ming Lei <tom.leiming@xxxxxxxxx>
>>
>> This patch fixes memory leak in ieee80211_send_probe_req, which
>> is introduced in 7c12ce8b854df346388ea56d684784e3484012cf:
>>
>> 	mac80211: use Probe Request template when sending a direct scan
>

[...]

>> @@ -1028,6 +1028,7 @@ void ieee80211_send_probe_req(struct ieee80211_sub_if_data *sdata, u8 *dst,
>>  
>>  	IEEE80211_SKB_CB(skb)->flags |= IEEE80211_TX_INTFL_DONT_ENCRYPT;
>>  	ieee80211_tx_skb(sdata, skb);
>> +	kfree(buf);
>
> Better to use dev_kfree_skb() here.

I don't know what I was thinking when I sent the previous email  :)

After second look, this looks good.

Reviewed-by: Kalle Valo <kalle.valo@xxxxxxxxx>

-- 
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux