On Fri, 2010-01-15 at 01:48 +0100, Benoit Papillault wrote: > ieee80211_set_power_mgmt is meant for STA interfaces only. Moreover, > since sdata->u.mgd.mtx is only initialized for STA interfaces, using > this code for any other type of interface (like IBSS) will result in a > oops. Odd that nobody else ever saw a problem, is everybody running cards that don't do power management? > diff --git a/net/mac80211/cfg.c b/net/mac80211/cfg.c > index 8286df5..c9de4e3 100644 > --- a/net/mac80211/cfg.c > +++ b/net/mac80211/cfg.c > @@ -1382,6 +1382,9 @@ static int ieee80211_set_power_mgmt(struct wiphy > *wiphy, struct net_device *dev, > struct ieee80211_local *local = wdev_priv(dev->ieee80211_ptr); > struct ieee80211_conf *conf = &local->hw.conf; > > + if (sdata->vif.type != NL80211_IFTYPE_STATION) > + return 0; You want -EOPNOTSUPP here, and cc stable. johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
