W dniu 15 stycznia 2010 00:44 użytkownik Luis R. Rodriguez <mcgrof@xxxxxxxxx> napisał: > 2010/1/14 Rafał Miłecki <zajec5@xxxxxxxxx>: >> W dniu 15 stycznia 2010 00:08 użytkownik Luis R. Rodriguez >> <mcgrof@xxxxxxxxx> napisał: >>> It'd be nice if your patches had a good description of what this is, I >>> see most of these patches are one-liners with no description at all. >> >> That's right, because I just implement function by function using >> specs. I guess that's how implementing driver from RE specs look like. >> >> Maybe I could use descriptions instead of function names so we would get >> calculate TX IQ LO >> instead of >> b43_nphy_cal_tx_iq_lo >> but not sure if that makes much more sense. >> >> Do you have some better suggestion? I'm open for comments, changes :) > > I'm talking about the text on the commit log after the "Subject", the > subject in this case being: > > "b43: N-PHY: add update TX cal ladder" > > Doesn't the spec talk or even speculate to some degree what this thing is? Well, AFAIK all we know about function is: http://bcm-v4.sipsolutions.net/802.11/PHY/N/UpdateTxCalLadder It updates something on wireless card writing table 15. It's hard to understand what it really does, especially if you don't yet have contexts calling this function. P.S. Also John's comment: <linville> "calculate TX IQ LO" -- I like that better So definitely I will avoid putting just function names. However as I said, I don't think I will be able to be more descriptive :/ -- Rafał -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
