On Sunday 10 January 2010 14:45:58 Johannes Berg wrote: > On Sun, 2010-01-10 at 14:43 +0100, Michael Buesch wrote: > > On Sunday 10 January 2010 14:40:39 Johannes Berg wrote: > > > See, it's not strictly forbidden to queue work, there's just no > > > > Ok, well. Lennert's mail sounded different to me. > > Ok. But would you agree with my assertion? I don't see what flushing it > again would buy us since after stop, it doesn't seem to matter when it > gets executed. Yeah, well. I was just thinking about possible existing driver bugs that depended on the current behavior to flush the workqueue after stop. Those would probably silently blow up. And as I thought (I might have been wrong) that there was a constraint on drv_stop callbacks to not being allowed to queue work, I thought it was a good idea to assert that. In my experience work flush bugs are hard to track down and debug, so... Well, not that this is important, but well... -- Greetings, Michael. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
