On Sunday 10 January 2010 14:07:53 Lennert Buytenhek wrote: > Since commit "mwl8k: handle station database update for AP's sta entry > via ->sta_notify()", mwl8k every now and then gets a command timeout > when ifconfig'ing a STA interface down. This turns out to be due to > mwl8k_stop() being called while the work queue item that was scheduled > by mwl8k_sta_notify() to remove the STA entry for the associated AP is > still queued, and the former disables interrupts so that when the > latter eventually runs, a command completion interrupt is never seen. > > Fix this by changing ieee80211_stop_device() so that the workqueue is > flushed before drv_stop() is called, instead of doing it the other way > around as is done now. (As ->stop() is allowed to sleep, there isn't > any reason for drivers to queue work from within it.) This smells like we should either: o Add an assertion that checks whether the driver queued work although it was forbidden. or o Call flush_workqueue twice. Once before and once after drv_stop. > Signed-off-by: Lennert Buytenhek <buytenh@xxxxxxxxxxx> > > diff --git a/net/mac80211/util.c b/net/mac80211/util.c > index bc73904..04680ca 100644 > --- a/net/mac80211/util.c > +++ b/net/mac80211/util.c > @@ -1077,9 +1077,9 @@ void ieee80211_stop_device(struct ieee80211_local *local) > ieee80211_led_radio(local, false); > > cancel_work_sync(&local->reconfig_filter); > - drv_stop(local); > > flush_workqueue(local->workqueue); > + drv_stop(local); > } > > int ieee80211_reconfig(struct ieee80211_local *local) -- Greetings, Michael. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
