On 01/06/2010 08:07 PM, Gertjan van Wingerde wrote: > On 01/06/10 17:35, Jiri Slaby wrote: >> @@ -717,6 +717,9 @@ int cfg80211_wext_siwscan(struct net_device *dev, >> out: >> cfg80211_unlock_rdev(rdev); >> return err; >> +out_free: >> + kfree(creq); >> + goto out; >> } >> EXPORT_SYMBOL_GPL(cfg80211_wext_siwscan); >> > > This last part looks a bit strange. Why don't you put out_free label before out label, Because `out' is a part of non-error flow, where the creq should not be freed. thanks, -- js -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
