Search Linux Wireless

Re: [PATCH 2/5] mac80211: fix propagation of failed hardware reconfigurations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Dec 24, 2009 at 4:38 AM, Johannes Berg
<johannes@xxxxxxxxxxxxxxxx> wrote:
> On Wed, 2009-12-23 at 20:03 -0500, Luis R. Rodriguez wrote:
>
>>       /* restart hardware */
>>       if (local->open_count) {
>> +             /*
>> +              * Upon resume hardware can sometimes be goofy due to
>> +              * various platform / driver / bus issues, so restarting
>> +              * the device may at times not work immediately. Propagate
>> +              * the error.
>> +              */
>>               res = drv_start(local);
>> +             if (res) {
>> +                     WARN(local->suspended, "Harware became unavailable "
>> +                          "upon resume likely due to a bug on mac80211, "
>> +                          "your driver or a bus issue\n");
>> +                     return res;
>> +             }
>
> I object to the wording -- how would this be a mac80211 bug? :)

Well it was in the first place, second, if another bug is lurking we
are likely to find it there. Are you 100% sure nothing else will creep
up?

  Luis
��.n��������+%������w��{.n�����{���zW����ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux