On 21.12.2009 16:08 Bob Copeland wrote: > I reviewed the patch, looks fine to me. The ATH hal uses a lookup > table to keep it inline but I don't think we have a convenient > index available to do the same. Yes, HAL uses a lookup table for mode -> clocks coversion, but before that can be used it has to convert channel flags to mode, and that's a sequence of ifs too (see function ath_hal_chan2wmode). If performance mattered, we could store the mode index somwhere. But it doesn't, the conversion is only needed when setting ACK timeout and slot time - which is, for most users, never done and defaults from initvals.c are used instead. Lukas Turek
Attachment:
signature.asc
Description: This is a digitally signed message part.