Johannes Berg <johannes@xxxxxxxxxxxxxxxx> writes: > On Mon, 2009-12-21 at 14:36 +0200, Kalle Valo wrote: > >> + cmd = kzalloc(sizeof(*cmd), GFP_KERNEL); >> + if (!cmd) >> + return -ENOMEM; >> + >> + /* copy the buffer to make it work with dma */ >> + memcpy(cmd, buf, buf_len); > > kmemdup() (more than once in the patch) Oh, of course I should have used that :) I'll change this. >> +#ifndef __WL1271_TESTMODE_H__ >> +#define __WL1271_TESTMODE_H__ >> + >> +#include <net/mac80211.h> >> + >> +int wl1271_tm_cmd(struct ieee80211_hw *hw, void *data, int len); >> + >> +#endif /* __WL1271_TESTMODE_H__ */ > > probably wouldn't bother with a file for one line ;) Yeah, you have a point. I added just for consistency. Thanks for the review. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
