On Wed, 2009-12-16 at 14:08 +0100, Roel Kluin wrote: > `queue' is unsigned so the test did not work. > > Signed-off-by: Roel Kluin <roel.kluin@xxxxxxxxx> > --- > Found using coccinelle: http://coccinelle.lip6.fr/ > > diff --git a/drivers/net/wireless/iwmc3200wifi/rx.c b/drivers/net/wireless/iwmc3200wifi/rx.c > index 1c57c1f..9ac72e4 100644 > --- a/drivers/net/wireless/iwmc3200wifi/rx.c > +++ b/drivers/net/wireless/iwmc3200wifi/rx.c > @@ -1128,7 +1128,7 @@ static int iwm_ntf_stop_resume_tx(struct iwm_priv *iwm, u8 *buf, > struct iwm_tx_queue *txq; > u16 queue = iwm_tid_to_queue(bit); > > - if (queue < 0) > + if (queue == -EINVAL) I think it's ugly. iwm_tid_to_queue() should return int if it's allowed to return error codes. -- Regards, Pavel Roskin -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
