On 15.12.2009 19:50 you wrote: > Can you move this last line setting the sc->ah->ah_coverage_class > to ath5k_hw_set_coverage_class() instead? ath5k_hw_set_coverage_class() is also called after interface reset: ath5k_hw_set_coverage_class(ah, ah->ah_coverage_class); So it would be quite strange if it set the value again... But I see your point, and don't see a better solution. > Also -- if an ath_hw_set_coverage_class(common, coverage_class) can be > defined on drivers/net/wireless/ath/hw.c along with: > > ath_hw_set_slot_time(common, slot_time), > ath_hw_set_ack_timeout(common, ack_timeout); > ath_hw_set_cts_timeout(common, cts_timeout); Unfortunately the functions are really hardware specific, they write a register that even differs between chip versions, and also depend on chip clock rate. It would be possible to move ath_hw_set_coverage_class() to ath to share the calculation, but that would require exporting six functions from the modules. > Wonder if ar9170 can support setting these too. It seems it supports setting slot time, but I don't see a register with ACK timeout, which is required too. Lukas Turek
Attachment:
signature.asc
Description: This is a digitally signed message part.
